Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing a TrainingService's company and saving can leave the browser unresponsive even though the POST completes and the record is saved. The observed Company picker contains 4,732 options, which the legacy Chosen widget duplicates into result rows and rebuilds after AJAX form replacement.
Use SilverStripe's supported
no-chznopt-out for this Company field only. The browser renders a native select; the full company list, selected value, CompanyID field, required validation and existing save/authorization path are preserved. The tradeoff is losing Chosen's searchable dropdown.This is a candidate mitigation for staging comparison, not a confirmed root-cause fix. Source review also identified uncancelled Chosen visibility retries and potentially expensive widget cleanup/layout during form replacement. No performance trace yet attributes the hang to any one of these paths.
Validation:
Before merging, compare baseline and native Company picker in isolated staging over repeated company-change/save cycles. Confirm persistence with a fresh form/database read, required-field validation, keyboard operation, and no accumulating detached widgets or timers. Record a trace before interacting/saving to distinguish JavaScript, layout and GC. If disabling Chosen does not resolve the stall, continue profiling rather than treating this as the fix.